Bump max gas wanted per tx to 60 mil #7833
Conversation
mattverse
added
the
V:state/compatible/no_backport
|
Warning Rate Limit Exceeded@czarcas7ic has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 24 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update primarily focuses on enhancing transaction capacity within the system. It does this by increasing the maximum gas limit allowed per transaction to 6 million. This adjustment aims to improve the network's efficiency and accommodate more complex transactions by allowing more computational work per transaction. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
I think we will need to add this to the config.toml overwrite flow to make this useful |
|
@czarcas7ic this original config was in app.toml, are you suggesting we move this to config.toml? |
|
Sorry I meant app.toml overwrite flow, there are two overwrite flows, one for each toml |
ValarDragon
changed the title
|
Because as far as I understand, this just makes it the default for when someone re initializes their configs, and that very very rarely occurs for validators. |
|
@czarcas7ic gotcha, good catch! added as requested |
|
While reviewing I realized we still had the same logic for app.toml override where we check if the value is the old value and then overrides (we now just override no matter what, and the node operator can provide the flag that prevents the override if they want to use their own values. I fixed that in a drive by, other than that should be good to go. |
* Bump max gas wanted per tx * Add changelog * Add app default values * drive by correct overwriteAppTomlValues logic * remove extra line in changelog * clean up --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> (cherry picked from commit 7b0c14a)
* Bump max gas wanted per tx * Add changelog * Add app default values * drive by correct overwriteAppTomlValues logic * remove extra line in changelog * clean up --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> (cherry picked from commit 7b0c14a) Co-authored-by: Matt, Park <[email protected]>
Closes: #XXX
What is the purpose of the change
Bumps max gas wanted per tx default to 6 million.
This would resolve all the issues projects were having when they were uploading contracts.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)Summary by CodeRabbit